-
Notifications
You must be signed in to change notification settings - Fork 53
Migrate from poetry to uv #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4e7471e
to
c19c0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
- Pulled local uv sync worked for me
- Make additions worked
- Pre-commit also working for local commit
- Generally faster seems like an improvement
@@ -27,7 +27,8 @@ class SchemaValidationError(RedisVLError): | |||
"""Error when validating data against a schema.""" | |||
|
|||
def __init__(self, message, index=None): | |||
if index is not None: | |||
# Only add index prefix if the message doesn't already contain detailed validation info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this is related to this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yeah when I reran the notebooks, the messages for schema validation warnings were driving me insane. Meant to pull that into a separate commit/branch. I can remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can stay in just wasn't sure if you wanted it as part of this one or not :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same some nice adds
Beyond poetry dependency resolution being the bane of my existence...
uv
is just better. Faster, stronger..This PR introduces
uv
as our new package manager and greatly improves the economics of our testing CI workflow on a few fronts: