Fix failing jruby tests, change default REDIS_BRANCH to 4.0 #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byroot
requested changes
May 25, 2018
.travis.yml
Outdated
| # jruby-openssl 0.9.21 required tests have been added above in the include section. | ||
| - rvm: jruby-9.1.17.0 | ||
| env: DRIVER=ruby REDIS_BRANCH=3.0 | ||
| - rvm: jruby-9.1.17.0 |
There was a problem hiding this comment.
I don't think it's worth running test we know will fail. If the fix for the jruby test suite is to use jruby-openssl < 0.10 then let's add this to the Gemfile / gemspec and that's it.
.travis.yml
Outdated
| @@ -33,7 +33,7 @@ env: | |||
| - DRIVER=hiredis REDIS_BRANCH=3.2 | |||
| - DRIVER=synchrony REDIS_BRANCH=3.0 | |||
| - DRIVER=synchrony REDIS_BRANCH=3.2 | |||
| - DRIVER=ruby REDIS_BRANCH=unstable | |||
| - DRIVER=ruby REDIS_BRANCH=stable | |||
There was a problem hiding this comment.
In think the intent of building unstable was to test 4.0. The build matrix could simply be 3.0 3.2 4.0.
ajlai
force-pushed
the
fix-buggy-jruby-tests
branch
from
5faa6a2 to
9a7b303
Compare
jruby tests fail when using jruby_openssl 0.10.0 but not when using 0.9.21 This change adds a Gemfile dependency for jruby_openssl <0.10.0 This change also switches the default REDIS_BRANCH to 4.0 since the unstable branch of redis isn't always in a buildable state. Also adds minor tweaks to how the tests are run due to minor issues with Gemfile usage.
ajlai
force-pushed
the
fix-buggy-jruby-tests
branch
from
9a7b303 to
775f860
Compare
ajlai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #756
jruby tests fail when using jruby_openssl 0.10.0 but not when using 0.9.21This change adds 0.9.21 to the travis build matrix and sets 0.10.0 as an allowed failure.
This change also switches the default REDIS_BRANCH to stable sincethe unstable branch of redis isn't always in a buildable state.
This change adds a Gemfile dependency for jruby_openssl <0.10.0
This change also switches the default REDIS_BRANCH to 4.0 since
the unstable branch of redis isn't always in a buildable state.
Also adds minor tweaks to how the tests are run due to minor issues with Gemfile / bundle usage.