Skip to content

4.0 #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Aug 25, 2017
Merged

4.0 #653

merged 41 commits into from
Aug 25, 2017

Conversation

djanowski
Copy link
Collaborator

No description provided.

bitterb and others added 30 commits February 2, 2013 11:07
@bitterb
Add support for CLIENT commands
aeadcc1
@djanowski
Remove Redis.connect.
895cc32
@djanowski
Remove Redis#[] and Redis#[]=.
c61ad43
@djanowski
Remove 1.8-ism.
5fd2630
@djanowski
Remove checks for Encoding.
0e1574f
@djanowski
Remove encoding mark.
9d7944e
@djanowski
Use require_relative.
f3bc68f
@djanowski
Remove Redis::Distributed.
c4ebeda
@djanowski
Switch to Makefile.
1feeab7
@byroot
Remove the deep dup in Client#options
3f966c9
@djanowski
Merge master into 4.0
1ba25a4
@djanowski
Clean up test helper.
5f34d8c
@djanowski
Remove unreliable test.
0c0d5ca
@djanowski
Merge remote-tracking branch 'origin/master' into 4.0
f8a00f5
@djanowski
Merge branch 'fix_write_to_socket' of quixoten/redis-rb into 4.0
ca1131d
@djanowski
This no longer needed.
c28de9b
@djanowski
Not targeting 1.8.
e8f0311
@djanowski
Fix warnings.
67429c3
@djanowski
More traces of 1.8.
a98f3a6
@djanowski
Apparently require_relative doesn't work in gemspec.
50f130d
@djanowski
The underlying client is now _client.
c239abb
@djanowski
Merge branch 'add-client-commands' of bitterb/redis-rb into 4.0
23cf899
@djanowski
No longer caring about backwards compatibility for Redis#client.
3138507
@djanowski
Update changelog for CLIENT commands.
5ec801d
@djanowski
Using make.
1529bda
@djanowski
Our new support matrix.
8a1e6c8
@djanowski
Fix requires.
39fa0f7
@djanowski
Refreshments.
9cd7510
@djanowski
Fix up requires and confusing environment variable names.
36af474
@djanowski
Try Ruby 2.3 with latest rvm.
31919c2
badboy
badboy reviewed Nov 24, 2016
View reviewed changes
.travis.yml Outdated
- rbx-2
- 2.3.3
- jruby-9
- rbx-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop rbx-3 testing/support as well? We allow failures anyway and usage of it is probably low anyway

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added quite recently. I think it doesn't hurt that a Rubinius user can quickly figure out whether redis-rb works on Rubinius or not...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, given that sometimes the tests work and sometimes they don't doesn't really give anyone any idea about the state of Rubinius support

@badboy badboy mentioned this pull request Dec 27, 2016
Merged
@jgoulah
Copy link

jgoulah commented Jan 12, 2017

Just curious about the decision to remove Redis::Distributed (I can't find any PR or discussion). When I attempted to use the 4.0.0-rc1 I am getting an error from redis-store cannot load such file -- redis/distributed and this version is also required by redis-rails which is at the newest version. While I understand its not your problem to support all these wrappers, it would be good to know why you dropped support in a totally backward incompatible way and some documentation on how to get around it. Is it as simple as not requiring redis/distributed any longer?

@djanowski djanowski merged commit 60971a1 into master Aug 25, 2017
@djanowski djanowski deleted the 4.0 branch August 25, 2017 16:19
@supercaracal supercaracal mentioned this pull request Dec 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy badboy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@djanowski @jgoulah @badboy @pje @bitterb @byroot @sallustfire