SLOWLOG GET Complexity Analysis #622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this. We use the complexity info a lot and had to customize our python parsing for this. |
|
+1 for this. |
|
Any updates here? @andymccurdy |
The [Garantia Data custom Redis version (Redis Labs' flavor)](https://github.com/RedisLabs/redis) returns `Complexity Info` as part of the `SLOWLOG GET` result. This commit helps handle those responses properly.
Testing the Garantia Data custom Redis result that includes complexity analysis Specifically, if the user's Redis instance isn't Garantia Data flavored, this test monkey patches `parse_response()` to include the complexity analysis part of the response the same way they do, and then tests for the expected response
|
@andymccurdy Any progress on this? |
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
|
This fix won't work on open-source Redis version 4+, since 2 new fields were added. |
ian28223
added a commit
to ian28223/redis-py
that referenced
this pull request
Jun 2, 2021
ian28223
added a commit
to ian28223/redis-py
that referenced
this pull request
Jun 2, 2021
4 tasks
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Garantia Data custom Redis version (Redis Labs' flavor) returns
Complexity infoas part of theSLOWLOG GETresult (see here).This pull request parses that data out and handles those responses properly.
Test included.