Skip to content

Fix: HSET unexpectedly mutates the list passed to items #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix: HSET unexpectedly mutates the list passed to items #3103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5017,14 +5017,16 @@ def hset(
"""
if key is None and not mapping and not items:
raise DataError("'hset' with no key value pairs")
items = items or []
pieces = []
if items:
pieces.extend(items)
if key is not None:
items.extend((key, value))
pieces.extend((key, value))
if mapping:
for pair in mapping.items():
items.extend(pair)
pieces.extend(pair)

return self.execute_command("HSET", name, *items)
return self.execute_command("HSET", name, *pieces)

def hsetnx(self, name: str, key: str, value: str) -> Union[Awaitable[bool], bool]:
"""
Expand Down