Skip to content

Fix Linting and Test Failures #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

grippy
Copy link
Contributor

@grippy grippy commented May 19, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)? Yes.
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested? Yes.
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? No.
  • Is there an example added to the examples folder (if applicable)? No.
  • Was the change added to CHANGES file? Not needed

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Issue: #2194

Fixes broken master linting and test failures.

@grippy grippy changed the title Ignore This Run Tests Against Master May 20, 2022
@grippy grippy mentioned this pull request May 20, 2022
6 tasks
@grippy grippy changed the title Run Tests Against Master Fix Linting and Test Failures May 20, 2022
@grippy grippy marked this pull request as ready for review May 20, 2022 21:44
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #2191 (29f97e9) into master (42b937f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         108      108              
  Lines       27393    27398       +5     
==========================================
+ Hits        25200    25204       +4     
- Misses       2193     2194       +1     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.01% <ø> (ø)
redis/commands/graph/commands.py 84.81% <ø> (ø)
redis/commands/json/commands.py 89.07% <ø> (ø)
redis/commands/redismodules.py 100.00% <ø> (ø)
redis/commands/search/commands.py 88.59% <ø> (ø)
redis/commands/core.py 82.99% <100.00%> (+0.01%) ⬆️
tests/test_asyncio/test_json.py 100.00% <100.00%> (ø)
tests/test_commands.py 89.92% <100.00%> (+0.04%) ⬆️
tests/test_json.py 100.00% <100.00%> (ø)
tests/test_asyncio/test_search.py 98.35% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428510b...29f97e9. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label May 23, 2022
@chayim
Copy link
Contributor

chayim commented May 23, 2022

LGTM. Thanks @grippy .

@oshadmi Can you please take a look at the JSON I linked you

Copy link

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@chayim chayim self-requested a review May 23, 2022 08:51
@chayim
Copy link
Contributor

chayim commented May 23, 2022

Thanks everyone! Merging in to master, in order to unblock anyone who does a direct clone.

@chayim chayim merged commit 8a1feb3 into redis:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants