Skip to content

Integrate RedisBloom support #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 1, 2021
Merged

Integrate RedisBloom support #1683

merged 13 commits into from
Dec 1, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Nov 9, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the 4.1.0 label Nov 10, 2021
@chayim chayim added the feature New feature label Nov 23, 2021
@ashtul
Copy link
Contributor

ashtul commented Nov 29, 2021

Fixes #1755

@chayim chayim changed the title Support redis bloom commands Integrate RedisBloom support Dec 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1683 (117e159) into master (175a05f) will increase coverage by 0.21%.
The diff coverage is 95.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   90.86%   91.08%   +0.21%     
==========================================
  Files          70       74       +4     
  Lines       15185    15596     +411     
==========================================
+ Hits        13798    14205     +407     
- Misses       1387     1391       +4     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
tests/test_bloom.py 91.28% <91.28%> (ø)
redis/commands/bf/commands.py 95.04% <95.04%> (ø)
redis/commands/bf/__init__.py 100.00% <100.00%> (ø)
redis/commands/bf/info.py 100.00% <100.00%> (ø)
redis/commands/redismodules.py 100.00% <100.00%> (ø)
redis/commands/search/aggregation.py 78.83% <0.00%> (-2.77%) ⬇️
tests/test_cluster.py 97.24% <0.00%> (-1.36%) ⬇️
redis/cluster.py 89.78% <0.00%> (-0.08%) ⬇️
redis/client.py 84.76% <0.00%> (-0.05%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175a05f...117e159. Read the comment docs.

@chayim chayim merged commit 42101fc into redis:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants