Fix ClassCastException in SearchStreamImpl count() method #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SylvainAssemat Thanks for the contribution. Unfortunately, I had already fixed it in the release 1.0.0 PR - it was broken in many places, so I wrote a helper function to deal with it. But please keep them coming! 🙏🏽 |
bsbodden
added a commit
to bsbodden/redis-om-spring
that referenced
this pull request
Aug 9, 2025
Fix ClassCastException when retrieving document count from Redis index info. Redis can return num_docs as either String or Long depending on version/config. Applied robust type checking to all occurrences: - RedisJSONKeyValueAdapter.count() - RedisEnhancedKeyValueAdapter.count() - RedisFluentQueryByExample (already fixed in SearchStreamImpl) The fix handles: - String values: parse to Long - Number values: convert to long - Null/unexpected: return 0L safely This is more robust than PR redis#640's approach as it: - Handles multiple Redis return types - Avoids NullPointerException - Prevents unnecessary String conversions - Provides safe fallback for unexpected types
bsbodden
added a commit
that referenced
this pull request
Aug 9, 2025
Fix ClassCastException when retrieving document count from Redis index info. Redis can return num_docs as either String or Long depending on version/config. Applied robust type checking to all occurrences: - RedisJSONKeyValueAdapter.count() - RedisEnhancedKeyValueAdapter.count() - RedisFluentQueryByExample (already fixed in SearchStreamImpl) The fix handles: - String values: parse to Long - Number values: convert to long - Null/unexpected: return 0L safely This is more robust than PR #640's approach as it: - Handles multiple Redis return types - Avoids NullPointerException - Prevents unnecessary String conversions - Provides safe fallback for unexpected types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639
Hotfix to solve this exeception on count() method in SearchStreamImpl.java