Adapt legacy sentinel tests to use the new test utils #2976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaradzhov
approved these changes
May 27, 2025
| @@ -1020,7 +1012,7 @@ describe.skip('legacy tests', () => { | |||
| this.timeout(30000); | |||
| const csc = new BasicPooledClientSideCache(); | |||
|
|
|||
| sentinel = frame.getSentinelClient({nodeClientOptions: {RESP: 3}, clientSideCache: csc, masterPoolSize: 5}); | |||
| sentinel = frame.getSentinelClient({nodeClientOptions: {RESP: 3 as const}, RESP: 3 as const, clientSideCache: csc, masterPoolSize: 5}); | |||
There was a problem hiding this comment.
why the double {RESP: 3 as const}, RESP: 3 as const,
There was a problem hiding this comment.
Without the second RESP: 3 as const, I was getting Client Side Caching is only supported with RESP3 error. I couldn't figure out why it was happening. Considering that the SentinelFramework is used only for testing, I didn't want to spend too much time on it.
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
* modified legacy sentinel tests * Adapt legacy sentinel tests to use the new test utils * modify tmpdir creation * reduced sentinel config timeouts, removed unneeded comment --------- Co-authored-by: H. Temelski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the sentinel test-util framework to be a wrapper of the generic test-utils. This allows us to create containers based on the command line arguments (used for testing with different redis versions in our CI/CD pipeline)
Checklist
npm testpass with this change (including linting)?