cancelCommandsOnReconnectFailure should have appropriate warnings.

[tawAsh1]

Feature Request

Is your feature request related to a problem? Please describe

These problems may be caused by cancelCommandsOnReconnectFailure being set to true.
#1753
#1645
#915

Describe the solution you'd like

When cancelCommandsOnReconnectFailure is true, reset() may be called if reconnect fails.
The reset() command can cause serious issue, as pointed out in these issues.

#907 (comment)
https://github.com/lettuce-io/lettuce-core/blob/ee3e70f613074531aef9874a01bbbeb72dbd2cbb/src/main/java/io/lettuce/core/RedisChannelWriter.java#L73

However, the cancelCommandsOnReconnectFailure option does not any warnings about the possibility of causing a protocol offset now.
https://github.com/lettuce-io/lettuce-core/blob/cda3be6b9477da790365ad098c6e39c8687f5002/src/main/java/io/lettuce/core/ClientOptions.java#L203
https://github.com/lettuce-io/lettuce-core/wiki/Client-Options

Therefore, at the least, these possibility should be fully explained.

[tokuhirom]

@mp911de

I think cancelCommandsOnReconnectFailure option should be deprecated. If I understand correctly, this option is not needed after Lettuce implements the SSL feature.

[mp911de]

These options were introduced indeed in a time where Lettuce SSL had to be used through SSL tunnels like stunnel. We should deprecate that option for removal with Lettuce 7. Do you want to submit a pull request?

[mp911de]

I updated the reference docs via https://github.com/lettuce-io/lettuce-core/wiki/Client-Options/_compare/4c890e4b690a4d1713d2944e57deb1476352ef2d...6a47d87c416f88c3a63120fe50aebb6eece4b7fe

[tawAsh1]

Since the impact of protocol offsets is critical, I think it is necessary not only to deprecate it, but also to announce it to the community if possible.

[mp911de]

Thanks a lot. We're going to mention it in the release notes properly.