RI-7873 Fix identifier field being cut off in create index form #5332
+54
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form Add padding-bottom to StyledContent to ensure the last identifier field is fully visible when scrolled to the bottom. Also add explicit flex properties to wrapper to ensure proper height constraints. This fixes a regression introduced by RI-7762 where forms were made to expand vertically, causing the identifier field to be cut off. References: #RI-7873
dantovska
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
pawelangelow,
pd-redis and
valkirilov
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
redisinsight/ui/src/pages/browser/components/create-redisearch-index/CreateRedisearchIndex.tsx
Outdated
Show resolved
Hide resolved
Contributor
Code Coverage - Frontend unit tests
Test suite run success5486 tests passing in 704 suites. Report generated by 🧪jest coverage report action from ab5017b |
valkirilov
previously approved these changes
Dec 16, 2025
… instead of component - Change IdentifierInfo from component usage to function call - Prevents React from unmounting/remounting on every render - Fixes tooltip losing hover/open state
valkirilov
approved these changes
Dec 16, 2025
dantovska
added a commit
that referenced
this pull request
Dec 18, 2025
* change the min-height to 100% to make sure all available space is taken * change the scroll to thin to match the add key style * surround AddMultipleFields with div, which actually fixes the issue * adjust surrounding spaces from spacer and cols to follow existing patterns * fix(ui): prevent identifier field from being cut off in create index form Add padding-bottom to StyledContent to ensure the last identifier field is fully visible when scrolled to the bottom. Also add explicit flex properties to wrapper to ensure proper height constraints. This fixes a regression introduced by RI-7762 where forms were made to expand vertically, causing the identifier field to be cut off. References: #RI-7873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the identifier field being cut off in the "Create new index" form. The field was scrollable but not entirely visible, creating poor UX.
This is a regression from RI-7762 where forms were made to expand vertically, which caused the identifier field to be cut off at the bottom.
Changes
Spacerimport (linter fix)Testing
Closes #RI-7873
Related: #RI-7762
Note
Adjusts layout and scrolling in the Create Index panel to prevent the last identifier field from being cut off, with minor spacing and header tweaks.
min-height: 100%forItemsWrapperinadd-multiple-fields/AddMultipleFields.styles.ts.CreateRedisearchIndexStyledContent(addsscrollbar-width: thin).xl→l), increase separator margin (HorizontalRules→m), and wrapAddMultipleFieldscontent in adiv.CreateRedisearchIndexWrapper: moveSpacer, addgap="xl", and use larger separator (HorizontalRulemarginl).Written by Cursor Bugbot for commit ab5017b. This will update automatically on new commits. Configure here.