Skip to content

RI-7347: Tips section slightly broken: links, voting... #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dantovska
Copy link
Collaborator

@dantovska dantovska commented Aug 19, 2025

Before After
image image
image image
image image
image image

How to test:

  1. Open an instance (go to Browser Page).
  2. Click on the Redis Insights bulb icon to view Tutorials and Tips.
image
  1. Click on the Tips.
  2. Open one of them. If none exist, click on the Run Database Analysis below.
image
  1. Expand one of the accordions.

Copy link
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.9% 19703/24058
🟡 Branches 67.22% 8540/12704
🟡 Functions 75.95% 5223/6877
🟢 Lines 82.33% 19288/23428

Test suite run success

5074 tests passing in 666 suites.

Report generated by 🧪jest coverage report action from 655a338

@pd-redis
Copy link
Collaborator

Are these changes - colors, fonts - because the design requires them?
Also, we are trying to move away from scss and custom colors. I would look for matching or similar color in the theme and use it.

@dantovska
Copy link
Collaborator Author

dantovska commented Aug 20, 2025

Are these changes - colors, fonts - because the design requires them? Also, we are trying to move away from scss and custom colors. I would look for matching or similar color in the theme and use it.

@pd-redis
If you referring to the recommendationsBgColor, I'm changing it in one place as where it's used I want to set the same color - greyish and not entirely white. This color is actually fixing the background for "Is this useful?" wrapper. I think this is the best best solution for this problem.
I'm not sure if we have discussed how to handle background styles for components though... maybe you are thinking of creating a styled wrapper component where we can just set a theme color instead of experimenting with the palette?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants