Skip to content

Add RedisClient::ClusterConfig#connect_timeout and #write_timeout #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Add RedisClient::ClusterConfig#connect_timeout and #write_timeout #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/redis_client/cluster_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,18 @@ def inspect
"#<#{self.class.name} #{startup_nodes.values.map { |v| v.reject { |k| k == :command_builder } }}>"
end

def connect_timeout
@client_config[:connect_timeout] || @client_config[:timeout] || ::RedisClient::Config::DEFAULT_TIMEOUT
end

def read_timeout
@client_config[:read_timeout] || @client_config[:timeout] || ::RedisClient::Config::DEFAULT_TIMEOUT
end

def write_timeout
@client_config[:write_timeout] || @client_config[:timeout] || ::RedisClient::Config::DEFAULT_TIMEOUT
end

def new_pool(size: 5, timeout: 5, **kwargs)
@client_implementation.new(
self,
Expand Down
2 changes: 2 additions & 0 deletions test/redis_client/test_cluster.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ def teardown

def test_config
refute_nil @client.config
refute_nil @client.config.connect_timeout
refute_nil @client.config.read_timeout
refute_nil @client.config.write_timeout
end

def test_inspect
Expand Down