This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Fix test-cleanup to use the generated CRD #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Macík <[email protected]>
pmacik
force-pushed
the
fix-test-cleanup
branch
from
46e6b43 to
3715e2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
=======================================
Coverage 61.19% 61.19%
=======================================
Files 26 26
Lines 1956 1956
=======================================
Hits 1197 1197
Misses 584 584
Partials 175 175 Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recent update to a new version of
operator-sdkchanged the way how the manifests (e.g. CRD) are generated and removed thedeploy/crd/*crd.yamlfile that was used in thetest-cleanupscript so now the script fails complaining that it could not find the file.Changes
This PR:
test-cleanupscript to the one that is generated by themanifeststarget.Testing
make test-cleanup