This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Use k8s api condition type for status.conditions #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedjak
force-pushed
the
use-k8s-conditions
branch
from
6571007 to
233c188
Compare
Condition type got available in 1.19 API. Hence, we can drop the usage of github.com/openshift/custom-resource-status library. Signed-off-by: Predrag Knezevic <[email protected]>
pedjak
force-pushed
the
use-k8s-conditions
branch
from
9d86788 to
efd1bde
Compare
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
+ Coverage 61.11% 61.47% +0.35%
==========================================
Files 25 25
Lines 1893 1918 +25
==========================================
+ Hits 1157 1179 +22
- Misses 565 568 +3
Partials 171 171
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akashshinde The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
akashshinde
added a commit
to akashshinde/service-binding-operator
that referenced
this pull request
Feb 3, 2021
added naming strategy and deprecated namePrefix and globalNamePrefix Fix acceptance tests fix etcd acceptance test Added flexible strategy naming docs Added doc to describe naming strategy remove service level naming strategy removed NamingStrategy field from service API revert back to default naming strategy Fix regression: previously create test namespace is used across test runs (redhat-developer#850) This fixes regression introduced in PR redhat-developer#848 - we should reuse created test namespace across multiple runs of acceptance tests Signed-off-by: Predrag Knezevic <[email protected]> Use k8s api condition type for status.conditions (redhat-developer#851) Condition type got available in 1.19 API. Hence, we can drop the usage of github.com/openshift/custom-resource-status library. Signed-off-by: Predrag Knezevic <[email protected]> Fix ServiceBinding removal when service not exist (redhat-developer#834) Signed-off-by: qibobo <[email protected]> Refactor Fix acceptance tests and revert back the docs go fmt Fix failures Fix acceptance test
akashshinde
added a commit
to akashshinde/service-binding-operator
that referenced
this pull request
Feb 4, 2021
added naming strategy and deprecated namePrefix and globalNamePrefix Fix acceptance tests fix etcd acceptance test Added flexible strategy naming docs Added doc to describe naming strategy remove service level naming strategy removed NamingStrategy field from service API revert back to default naming strategy Fix regression: previously create test namespace is used across test runs (redhat-developer#850) This fixes regression introduced in PR redhat-developer#848 - we should reuse created test namespace across multiple runs of acceptance tests Signed-off-by: Predrag Knezevic <[email protected]> Use k8s api condition type for status.conditions (redhat-developer#851) Condition type got available in 1.19 API. Hence, we can drop the usage of github.com/openshift/custom-resource-status library. Signed-off-by: Predrag Knezevic <[email protected]> Fix ServiceBinding removal when service not exist (redhat-developer#834) Signed-off-by: qibobo <[email protected]> Refactor Fix acceptance tests and revert back the docs go fmt Fix failures Fix acceptance test
akashshinde
added a commit
to akashshinde/service-binding-operator
that referenced
this pull request
Feb 4, 2021
added naming strategy and deprecated namePrefix and globalNamePrefix Fix acceptance tests fix etcd acceptance test Added flexible strategy naming docs Added doc to describe naming strategy remove service level naming strategy removed NamingStrategy field from service API revert back to default naming strategy Fix regression: previously create test namespace is used across test runs (redhat-developer#850) This fixes regression introduced in PR redhat-developer#848 - we should reuse created test namespace across multiple runs of acceptance tests Signed-off-by: Predrag Knezevic <[email protected]> Use k8s api condition type for status.conditions (redhat-developer#851) Condition type got available in 1.19 API. Hence, we can drop the usage of github.com/openshift/custom-resource-status library. Signed-off-by: Predrag Knezevic <[email protected]> Fix ServiceBinding removal when service not exist (redhat-developer#834) Signed-off-by: qibobo <[email protected]> Refactor Fix acceptance tests and revert back the docs go fmt Fix failures Fix acceptance test
akashshinde
added a commit
that referenced
this pull request
Feb 5, 2021
added naming strategy and deprecated namePrefix and globalNamePrefix Fix acceptance tests fix etcd acceptance test Added flexible strategy naming docs Added doc to describe naming strategy remove service level naming strategy removed NamingStrategy field from service API revert back to default naming strategy Fix regression: previously create test namespace is used across test runs (#850) This fixes regression introduced in PR #848 - we should reuse created test namespace across multiple runs of acceptance tests Signed-off-by: Predrag Knezevic <[email protected]> Use k8s api condition type for status.conditions (#851) Condition type got available in 1.19 API. Hence, we can drop the usage of github.com/openshift/custom-resource-status library. Signed-off-by: Predrag Knezevic <[email protected]> Fix ServiceBinding removal when service not exist (#834) Signed-off-by: qibobo <[email protected]> Refactor Fix acceptance tests and revert back the docs go fmt Fix failures Fix acceptance test Signed-off-by: akashshinde <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition type got available in 1.19 API. Hence, we can drop the usage of
github.com/openshift/custom-resource-status library.