Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

baijum
Copy link
Contributor

@baijum baijum commented Dec 14, 2022

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Baiju Muthukadan <[email protected]>
@openshift-ci openshift-ci bot requested review from filariow and sadlerap December 14, 2022 09:59
@baijum
Copy link
Contributor Author

baijum commented Dec 14, 2022

/test 4.9-acceptance

@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Dec 14, 2022
@pmacik
Copy link
Contributor

pmacik commented Dec 14, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor

pmacik commented Dec 14, 2022

/retest

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1319 (b571d75) into master (b397f86) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1319   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b397f86...b571d75. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 5204c03 into redhat-developer:master Dec 14, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Dec 14, 2022
Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Dec 14, 2022
Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Baiju Muthukadan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants