Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

baijum
Copy link
Contributor

@baijum baijum commented Nov 7, 2022

This is removed in Kubernetes 1.22
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik
Copy link
Contributor

pmacik commented Nov 7, 2022

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Nov 7, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1300 (628864a) into master (4810c32) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4810c32...628864a. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 6cb409e into redhat-developer:master Nov 7, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Nov 7, 2022
@pmacik pmacik added release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch and removed release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Nov 7, 2022
@baijum baijum deleted the crd-v1beta1 branch November 11, 2022 04:25
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 11, 2023
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 11, 2023
openshift-merge-robot pushed a commit that referenced this pull request Jan 11, 2023
This is removed in Kubernetes 1.22
https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Baiju Muthukadan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants