Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

filariow
Copy link
Contributor

Changes

Fix an error in the deploy/uninstall rule.
The kubectl dependency was added to .PHONY instead of to the uninstall rule's dependencies.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Francesco Ilario <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1293 (7474558) into master (1a1a1fe) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1a1fe...7474558. Read the comment docs.

@filariow filariow marked this pull request as ready for review October 27, 2022 10:47
@pmacik
Copy link
Contributor

pmacik commented Oct 27, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 120dad9 into redhat-developer:master Oct 27, 2022
@filariow filariow deleted the pr-fix-makefiles branch October 27, 2022 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants