Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Bump version of Go to v1.18 and fix CVE-2022-32149 #1275

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 18, 2022

Signed-off-by: Pavel Macík [email protected]

Go 1.17 is EOL

Changes

This PR:

  • Upgrades go to v1.18
  • Fixes HIGH security vulnerability (CVE-2022-32149)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci openshift-ci bot requested review from filariow and sadlerap October 18, 2022 12:56
@sadlerap
Copy link
Contributor

Do the test projects under test/_projects also need to be upgraded to go 1.18?

@pmacik pmacik force-pushed the go-1.18 branch 2 times, most recently from b4edcfa to 781174f Compare October 18, 2022 13:33
Signed-off-by: Pavel Macík <[email protected]>
@sadlerap
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1275 (0971cc3) into master (fd11127) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1275   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd11127...0971cc3. Read the comment docs.

@baijum
Copy link
Contributor

baijum commented Oct 19, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ba95a74 into redhat-developer:master Oct 19, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Oct 19, 2022
Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
@pmacik pmacik changed the title Bump version of Go to v1.18 Bump version of Go to v1.18 and fix CVE-2022-32149 Oct 19, 2022
@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Oct 19, 2022
pmacik added a commit that referenced this pull request Oct 19, 2022
openshift-merge-robot pushed a commit that referenced this pull request Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants