Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Stop using deprecated features in GH actions #1274

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 18, 2022

Signed-off-by: Pavel Macík [email protected]

Github Actions give the following warning about deprecating node12 based actions:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: ...

and the following warning about deprecating use of set-output command:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Changes

This PR:

  • Updates version of actions that use node12 to versions that use node16.
  • Replaces usage of set-outout command by writting to the new GITHUB_OUTPUT environment variable

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 18, 2022
@openshift-ci openshift-ci bot requested review from baijum and filariow October 18, 2022 11:20
@pmacik pmacik changed the title Update GH actions that use deprecated node12 to versions with node16 WIP: Update GH actions that use deprecated node12 to versions with node16 Oct 18, 2022
@pmacik pmacik force-pushed the fix-gha branch 2 times, most recently from c471b50 to 25ce09a Compare October 18, 2022 12:13
@pmacik pmacik changed the title WIP: Update GH actions that use deprecated node12 to versions with node16 Update GH actions that use deprecated node12 to versions with node16 Oct 18, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Oct 18, 2022

/retest

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1274 (b493547) into master (ca91ac5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca91ac5...b493547. Read the comment docs.

@pmacik pmacik force-pushed the fix-gha branch 2 times, most recently from e0bd224 to bcec010 Compare October 19, 2022 16:37
@pmacik
Copy link
Contributor Author

pmacik commented Oct 19, 2022

/retest

@pmacik pmacik force-pushed the fix-gha branch 2 times, most recently from f2a2fc4 to 4a1ccc9 Compare October 20, 2022 08:40
@pmacik pmacik changed the title Update GH actions that use deprecated node12 to versions with node16 Update GH actions to stop using deprecated features Oct 20, 2022
@pmacik pmacik changed the title Update GH actions to stop using deprecated features Stop using deprecated features in GH actions Oct 20, 2022
@baijum
Copy link
Contributor

baijum commented Oct 20, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor Author

pmacik commented Oct 21, 2022

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Oct 22, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6eb10a5 into redhat-developer:master Oct 22, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 22, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 22, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 22, 2022
openshift-merge-robot pushed a commit that referenced this pull request Oct 22, 2022
Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
Co-authored-by: Pavel Macík <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Oct 22, 2022
Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
Co-authored-by: Pavel Macík <[email protected]>
pmacik added a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants