Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Oct 4, 2022

Signed-off-by: Andy Sadler [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Andy Sadler <[email protected]>
@openshift-ci openshift-ci bot requested review from baijum and pmacik October 4, 2022 17:58
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1249 (cc303ff) into master (da43554) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1249   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da43554...cc303ff. Read the comment docs.

Copy link
Contributor

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit 386cd8e into redhat-developer:master Oct 5, 2022
@sadlerap sadlerap deleted the owners branch October 5, 2022 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants