Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 30, 2022

Signed-off-by: Pavel Macík [email protected]

Changes

Tags the acceptance testing scenarios that use OLM descriptors by the @olm-descriptors tag.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@baijum
Copy link
Contributor

baijum commented Sep 30, 2022

/lgtm
/approve

@pmacik
Copy link
Contributor Author

pmacik commented Sep 30, 2022

/retest

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum, dperaza4dustbit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [baijum,dperaza4dustbit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor Author

pmacik commented Sep 30, 2022

/retest

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1245 (5c432d7) into master (a0f4e76) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f4e76...5c432d7. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit da43554 into redhat-developer:master Sep 30, 2022
@pmacik pmacik added release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch labels Oct 4, 2022
pmacik added a commit that referenced this pull request Oct 4, 2022
Signed-off-by: Pavel Macík <[email protected]>

Signed-off-by: Pavel Macík <[email protected]>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants