This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Extend the acceptance testing framework to support installing operator with both manual and automatic subscriptions #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
…r with both manual and automatic subscriptions Signed-off-by: Pavel Macík <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 58.08% 58.08%
=======================================
Files 33 33
Lines 2839 2839
=======================================
Hits 1649 1649
Misses 1029 1029
Partials 161 161 Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmacik
added a commit
that referenced
this pull request
Aug 22, 2022
…r with both manual and automatic subscriptions (#1193) Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 24, 2022
…r with both manual and automatic subscriptions (redhat-developer#1193) Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 25, 2022
…r with both manual and automatic subscriptions (redhat-developer#1193) Signed-off-by: Pavel Macík <[email protected]>
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 26, 2022
…r with both manual and automatic subscriptions (redhat-developer#1193) Signed-off-by: Pavel Macík <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík [email protected]
Ref: https://issues.redhat.com/browse/APPSVC-1151
Changes
This PR:
Operator.install_operator_subscription()method with additional optional parameterinstall_node(with "Automatic" as the default).Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.