This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Print subject access review error to logs. #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Macík <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
==========================================
- Coverage 58.71% 58.69% -0.03%
==========================================
Files 33 33
Lines 2781 2782 +1
==========================================
Hits 1633 1633
- Misses 987 988 +1
Partials 161 161
Continue to review full report at Codecov.
|
|
/lgtm |
|
/approved |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmacik
added a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 25, 2022
Signed-off-by: Pavel Macík <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel Macík [email protected]
Related to: #1172
Changes
Currently, if error occurs which is related to getting Subject Access Review for a ClusterWorkloadResourceMapping resources. The error is not shown to explain the reason and only the
falsevalue is returned.This PR adds an error log for such events to see the root cause of the error.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.