This repository was archived by the owner on Jun 26, 2024. It is now read-only.
webhooks: validate workload resource mapping resources #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 57.84% 58.71% +0.87%
==========================================
Files 31 33 +2
Lines 2697 2781 +84
==========================================
+ Hits 1560 1633 +73
- Misses 976 987 +11
Partials 161 161
Continue to review full report at Codecov.
|
baijum
suggested changes
Jun 7, 2022
sadlerap
force-pushed
the
validate-mapping-resources
branch
from
9e9c001 to
0d27d5e
Compare
Implement validation webhooks for incoming & modified ClusterWorkloadResourceMapping.servicebinding.io resources. Deletion is left unhandled; it's not clear if we need to implement deletion validation. Signed-off-by: Andy Sadler <[email protected]>
sadlerap
force-pushed
the
validate-mapping-resources
branch
from
0d27d5e to
ebe6afd
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement validation webhooks for incoming & modified ClusterWorkloadResourceMapping.servicebinding.io resources. Deletion is left unhandled; it's not clear if we need to implement deletion validation.
Signed-off-by: Andy Sadler [email protected]
Changes
/kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.