Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Jun 1, 2022

In #1142 ("Updates to upstream to sync with downstream content"), docs/userguide/modules/creating-service-bindings was moved to docs/userguide/modules/binding-workloads-using-sbo, and its content was changed to reflect documentation changes downstream. However, this first directory was kept around, leaving stale documentation in our repository. This change removes this directory and its stale documentation to prevent further confusion.

Signed-off-by: Andy Sadler [email protected]

Changes

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

In redhat-developer#1142 ("Updates to upstream to sync with downstream content"),
`docs/userguide/modules/creating-service-bindings` was moved to
`docs/userguide/modules/binding-workloads-using-sbo`, and its content
was changed to reflect documentation changes downstream.  However, this
first directory was kept around, leaving stale documentation in our
repository.  This change removes this directory and its stale
documentation to prevent further confusion.

Signed-off-by: Andy Sadler <[email protected]>
@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label Jun 1, 2022
@openshift-ci openshift-ci bot requested review from baijum and dperaza4dustbit June 1, 2022 20:25
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1159 (9a05f11) into master (65ea52d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files          31       31           
  Lines        2697     2697           
=======================================
  Hits         1560     1560           
  Misses        976      976           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ea52d...9a05f11. Read the comment docs.

@pmacik
Copy link
Contributor

pmacik commented Jun 1, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 28b1195 into redhat-developer:master Jun 1, 2022
@pmacik pmacik added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants