Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Apr 11, 2022

Signed-off-by: Pavel Macík [email protected]

Changes

codecov/codecov-action@v1 has been deprecated, so this PR upgrades the version to the latest version ATM (v3)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the ci CI related issues label Apr 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pmacik after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik pmacik force-pushed the update-codecov-action-v2 branch from d7c5b0d to ff6c1a2 Compare April 11, 2022 13:49
@pmacik pmacik changed the title Upgrade codecov-action from deprecated v1 to v2 Upgrade codecov-action from deprecated v1 to v3 Apr 11, 2022
@pmacik pmacik force-pushed the update-codecov-action-v2 branch from ff6c1a2 to 01aecc4 Compare April 11, 2022 13:52
@pmacik pmacik force-pushed the update-codecov-action-v2 branch from 01aecc4 to f363eb2 Compare April 11, 2022 13:54
@pmacik pmacik added the kind/enhancement New feature or request label Apr 11, 2022
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pmacik
Copy link
Contributor Author

pmacik commented Apr 11, 2022

/retest

2 similar comments
@pmacik
Copy link
Contributor Author

pmacik commented Apr 11, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Apr 11, 2022

/retest

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1129 (f363eb2) into master (c9ab9c3) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
- Coverage   58.92%   58.30%   -0.62%     
==========================================
  Files          30       30              
  Lines        1670     2336     +666     
==========================================
+ Hits          984     1362     +378     
- Misses        560      848     +288     
  Partials      126      126              
Impacted Files Coverage Δ
pkg/converter/unstructured.go 18.91% <0.00%> (-3.31%) ⬇️
...kg/reconcile/pipeline/context/spec_binding_impl.go 69.56% <0.00%> (-2.99%) ⬇️
pkg/binding/jsonpath.go 66.66% <0.00%> (-2.57%) ⬇️
pkg/reconcile/pipeline/secretbackedbindings.go 64.28% <0.00%> (-2.39%) ⬇️
pkg/binding/spec.go 70.58% <0.00%> (-2.14%) ⬇️
pkg/reconcile/pipeline/handler/project/impl.go 61.11% <0.00%> (-1.89%) ⬇️
apis/spec/v1alpha3/servicebinding_webhook.go 65.38% <0.00%> (-1.29%) ⬇️
apis/binding/v1alpha1/servicebinding_webhook.go 65.38% <0.00%> (-1.29%) ⬇️
pkg/naming/naming.go 86.36% <0.00%> (-1.14%) ⬇️
pkg/reconcile/pipeline/builder/pipeline.go 92.50% <0.00%> (-0.36%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ab9c3...f363eb2. Read the comment docs.

@pmacik pmacik merged commit 78327d1 into redhat-developer:master Apr 12, 2022
@pmacik pmacik deleted the update-codecov-action-v2 branch May 11, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci CI related issues kind/enhancement New feature or request lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants