Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

Kartikey-star
Copy link
Contributor

@Kartikey-star Kartikey-star commented Feb 17, 2022

This PR adds yaml files to samples/apps/spring-petclinic which are used to create spring petclinic application deployment compatible with mysql and also the custom resource yaml for creating instance of PerconaXtraDB cluster

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • Follows the commit message standard

@Kartikey-star Kartikey-star changed the title Added petclinic deployment for mysql and mysqlcluster-deployment for… Added petclinic deployment for mysql and mysqlcluster-deployment for creating instance of PerconaXtraDB cluster Feb 17, 2022
@Kartikey-star Kartikey-star reopened this Feb 17, 2022
@pmacik
Copy link
Contributor

pmacik commented Feb 17, 2022

@Kartikey-star please fix the PR's description

@Kartikey-star Kartikey-star changed the title Added petclinic deployment for mysql and mysqlcluster-deployment for creating instance of PerconaXtraDB cluster Added Spring Petclinic Application Deployment yaml compatible with MySQL and custom resource yaml for creating instance of PerconaXtraDB cluster Feb 17, 2022
@Kartikey-star
Copy link
Contributor Author

Kartikey-star commented Feb 17, 2022

@pmacik

Changed to 'Added Spring Petclinic Application Deployment yaml compatible with MySQL and custom resource yaml for creating instance of PerconaXtraDB cluster'

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1107 (fbf7ff4) into master (0dd86ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files          30       30           
  Lines        1670     1670           
=======================================
  Hits          984      984           
  Misses        560      560           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd86ce...fbf7ff4. Read the comment docs.

@baijum
Copy link
Contributor

baijum commented Feb 21, 2022

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Feb 21, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kartikey-star
Copy link
Contributor Author

/retest

1 similar comment
@Kartikey-star
Copy link
Contributor Author

/retest

@pmacik
Copy link
Contributor

pmacik commented Feb 21, 2022

@Kartikey-star you likely need to rebase since the #1106 has merged

…creating instance of PerconaXtraDBCluster

Signed-off-by: Kartikey Mamgain <[email protected]>
@baijum
Copy link
Contributor

baijum commented Feb 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2022
@baijum
Copy link
Contributor

baijum commented Feb 22, 2022

/test 4.9-acceptance

@openshift-merge-robot openshift-merge-robot merged commit 31151ab into redhat-developer:master Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants