Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Jan 12, 2022

Tekton project
already has instructions that align with our values, and hence the important sections
are borrowed from there.

@openshift-ci openshift-ci bot requested review from jasperchui and pmacik January 12, 2022 16:38
@pedjak pedjak requested review from sadlerap and baijum and removed request for jasperchui January 12, 2022 16:39
@pedjak pedjak force-pushed the update-contrib-guide branch from bf0ab7e to 3529076 Compare January 12, 2022 16:40
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one minor issue, this should be good.
/lgtm

[Tekton project](https://github.com/tektoncd/community/blob/main/standards.md)
already has instructions that align with our values, and hence the important sections
are borrowed from there.

Signed-off-by: Predrag Knezevic <[email protected]>
@pedjak pedjak force-pushed the update-contrib-guide branch from 3529076 to 4c73653 Compare January 12, 2022 17:04
@openshift-ci openshift-ci bot removed the lgtm label Jan 12, 2022
@sadlerap
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1091 (4c73653) into master (dfd90c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files          30       30           
  Lines        1670     1670           
=======================================
  Hits          984      984           
  Misses        560      560           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd90c6...4c73653. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 9f56de6 into redhat-developer:master Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants