Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

sadlerap
Copy link
Contributor

Motivation

We need this to enable local testing on minikube clusters; cert-manager's v1beta1 resources were deprecated.

Changes

Updates the deploy-cert-manager make rule to use cert-manager v1.6.0.

Testing

Deploy a cluster using make deploy.

@openshift-ci openshift-ci bot requested review from baijum and pmacik January 10, 2022 17:03
@sadlerap
Copy link
Contributor Author

/retest

@pedjak
Copy link
Contributor

pedjak commented Jan 10, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pedjak
Copy link
Contributor

pedjak commented Jan 10, 2022

/retest

@baijum
Copy link
Contributor

baijum commented Jan 11, 2022

/test 4.10-acceptance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-acceptance 6e5da5f link true /test 4.10-acceptance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmacik
Copy link
Contributor

pmacik commented Jan 11, 2022

The Bind test application to Postgres instance provisioned by Cloud Native Postgres operator test fails for OpenShift 4.10 because the Cloud Native Postgres operator is not available in 4.10 catalog.

@pedjak pedjak merged commit dfd90c6 into redhat-developer:master Jan 11, 2022
@pedjak
Copy link
Contributor

pedjak commented Jan 11, 2022

The Bind test application to Postgres instance provisioned by Cloud Native Postgres operator test fails for OpenShift 4.10 because the Cloud Native Postgres operator is not available in 4.10 catalog.

Merged manually

@sadlerap sadlerap deleted the cert-manager branch January 11, 2022 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants