Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Dec 10, 2021

The appropriate database host name is stored in .status.writeService field, and it is NOT
equal to Postgres resource name.

Changes:

  • servicebinding host annotation got updated
  • added provider binding, the value is set to enterprisedb
  • generic test application is extended with /postgres-ready endpoint that
    returns OK if the connection to Postgres database can be established using the provided bindings
  • New version of the test application got pushed to the registry for all supported arches
  • Cloud Native Postgres acceptance test got update to assert the database connection

Fixes #1077

…tive Postgres Operator

The appropriate database host name is stored in `.status.writeService` field, and it is NOT
equal to `Postgres` resource name.

Changes:
* servicebinding host annotation got updated
* added `provider` binding, the value is set to `enterprisedb`
* generic test application is extended with `/postgres-ready` endpoint that
returns `OK` if the connection to Postgres database can be established using the provided bindings
* New version of the test application got pushed to the registry for all supported arches
* Cloud Native Postgres acceptance test got update to assert the database connection

Signed-off-by: Predrag Knezevic <[email protected]>
@openshift-ci openshift-ci bot requested review from baijum and isutton December 10, 2021 15:54
@pedjak pedjak requested review from pmacik and removed request for isutton December 10, 2021 15:54
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1081 (1d2df29) into master (1f72711) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files          30       30           
  Lines        1670     1670           
=======================================
  Hits          984      984           
  Misses        560      560           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f72711...1d2df29. Read the comment docs.

@pedjak
Copy link
Contributor Author

pedjak commented Dec 14, 2021

@pmacik could provsion an ARM based cluster and the generic test application works there as well?

Copy link
Contributor

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2021

@pmacik could provsion an ARM based cluster and the generic test application works there as well?

yes, I'll do that

@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2021

I can confirm, that new generic test app works on arm64 cluster

@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 36f271e into redhat-developer:master Dec 15, 2021
@pmacik pmacik added this to the 1.0.1 milestone Feb 16, 2022
@pmacik pmacik added the kind/bug Something isn't working label Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad data with edg postgress operator created databse
4 participants