Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Document registry in README.md #1058

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Document registry in README.md #1058

merged 1 commit into from
Oct 14, 2021

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Oct 12, 2021 •
edited
Loading

Motivation

We need to document very clearly the following:

  • Which operators are supported in the registry
  • What limitations the operators in the registry have
  • Our intention to ultimately remove the registry from SBO

Changes

This documents the registry in our readme.

Testing

Read the readme.

@openshift-ci openshift-ci bot requested review from jasperchui and pmacik October 12, 2021 17:13
@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

Merging #1058 (291c32d) into master (1dfd5bf) will not change coverage.
The diff coverage is n/a.

❗ Current head 291c32d differs from pull request most recent head 8b146fd. Consider uploading reports for the commit 8b146fd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1058   +/-   ##
=======================================
  Coverage   58.87%   58.87%           
=======================================
  Files          30       30           
  Lines        1668     1668           
=======================================
  Hits          982      982           
  Misses        560      560           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfd5bf...8b146fd. Read the comment docs.

pedjak
pedjak reviewed Oct 12, 2021
View reviewed changes
@sadlerap
Copy link
Contributor Author

/retest

@sadlerap sadlerap requested review from pedjak and removed request for jasperchui October 13, 2021 16:17
pedjak
pedjak reviewed Oct 13, 2021
View reviewed changes
pedjak
pedjak reviewed Oct 13, 2021
View reviewed changes
pedjak
pedjak approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm please squash

@sadlerap
Copy link
Contributor Author

/test 4.9-acceptance

@sadlerap
Document registry in README.md
7398e59 
We need to document *very clearly* the following:
- Which operators are supported in the registry
- What limitations the operators in the registry have
- Our intention to ultimately remove the registry from SBO

Signed-off-by: Andy Sadler <[email protected]>
@pedjak
Copy link
Contributor

pedjak commented Oct 14, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8197b2e into redhat-developer:master Oct 14, 2021
@sadlerap sadlerap deleted the readme-updates branch October 14, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmacik pmacik Awaiting requested review from pmacik

1 more reviewer

@pedjak pedjak pedjak approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pedjak pedjak

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sadlerap @pedjak @pmacik @openshift-merge-robot