This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Remove BindableKinds CR from samples #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/hold |
|
/hold |
Signed-off-by: Pavel Macík <[email protected]>
pmacik
force-pushed
the
bindable-kinds-spec-cvp
branch
from
df42f29 to
0e3ed94
Compare
pmacik
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum, pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
=======================================
Coverage 58.87% 58.87%
=======================================
Files 30 30
Lines 1668 1668
=======================================
Hits 982 982
Misses 560 560
Partials 126 126 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, sample
BindableKindsCR included in CSV does not contain.specbloc, because its API does not have Spec in.That fails
basic-check-spec-testof OperatorSDK's scorecard tests.BindableKindsis supposed to be a singleton instance in a cluster and is only used by the operator to publish set of bindable kinds. The CRs are not supposed to be created by users and therefore having an example for users does not make much sense.Changes
This PR:
BindableKindsTesting