This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Move annotation registry into dedicated package #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacik
reviewed
Oct 11, 2021
`bindingAnnotations` map has been moved from CRD controller into `pkg/binding/registry` package and exposed through `ServiceAnnotations` component. This change enables operator backend-service support also when SBO is used as library. Signed-off-by: Predrag Knezevic <[email protected]>
pedjak
force-pushed
the
registry-refactor
branch
from
f96d08a to
17c9f50
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 58.68% 58.87% +0.18%
==========================================
Files 30 30
Lines 1663 1668 +5
==========================================
+ Hits 976 982 +6
+ Misses 561 560 -1
Partials 126 126
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindingAnnotationsmap has been moved from CRD controller intopkg/binding/registrypackageand exposed through
ServiceAnnotationscomponent.This change enables operator backend-service support also when SBO is used as library.