registry: add support for percona mongodb clusters #1050
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
=======================================
Coverage 58.68% 58.68%
=======================================
Files 30 30
Lines 1663 1663
=======================================
Hits 976 976
Misses 561 561
Partials 126 126 Continue to review full report at Codecov.
|
sadlerap
force-pushed
the
percona-mongodb
branch
from
0451036 to
1e512f8
Compare
sadlerap
force-pushed
the
percona-mongodb
branch
from
1e512f8 to
bde4a7c
Compare
| @@ -158,3 +158,117 @@ Feature: Support a number of existing operator-backed services out of the box | |||
| hippo | |||
| """ | |||
| And File "/bindings/$scenario_id/password" exists in application pod | |||
|
|
|||
| Scenario: Bind test application to MongoDB provisioned by Percona's MongoDB operator | |||
| Given Crunchy Data Postgres operator is running | |||
There was a problem hiding this comment.
you need here MongoDB operator running, not Postgres :)
| def install_percona_mongodb_operator(_context): | ||
| operator = PerconaMongoDBOperator() | ||
| if not operator.is_running(): | ||
| operator.install_operator_subscription() | ||
| operator.is_running(wait=True) | ||
| print("Percona MongoDB operator is running") |
There was a problem hiding this comment.
This operator is not installed globally, it does not support AllNamespaces feature, take a look at their release.yaml on OperatorHub. Hence, you need to apply here similar approach to their Postgres operator, check https://github.com/redhat-developer/service-binding-operator/blob/master/test/acceptance/features/steps/percona_mysql_operator.py#L19 for the details.
pedjak
force-pushed
the
percona-mongodb
branch
from
bde4a7c to
84f931d
Compare
|
/retest |
pedjak
force-pushed
the
percona-mongodb
branch
6 times, most recently
from
e939a5b to
5e56ab4
Compare
Percona is one of the better-used database providers in k8s. Supporting them as best as we can in SBO will be to our benefit. Signed-off-by: Andy Sadler <[email protected]>
pedjak
force-pushed
the
percona-mongodb
branch
from
5e56ab4 to
75b43fd
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/hold cancel |
Percona is one of the better-used database providers in k8s. Supporting them as best as we can in SBO will be to our benefit.
Motivation
Since Percona doesn't require invasive changes into the operator to support at least some amount of binding, we should try to support it.
Changes
This adds RBAC rules and an acceptance test as a part of this work.