Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 6, 2021

Motivation

Follows up to #1034

Changes

This PR:

Testing

@openshift-ci openshift-ci bot requested review from isutton and sadlerap October 6, 2021 12:16
@pedjak
Copy link
Contributor

pedjak commented Oct 6, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1044 (17f3d24) into master (c509e4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   58.11%   58.11%           
=======================================
  Files          29       29           
  Lines        1645     1645           
=======================================
  Hits          956      956           
  Misses        563      563           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c509e4e...17f3d24. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 3bae39b into redhat-developer:master Oct 6, 2021
@pmacik pmacik deleted the goodbye-examples branch May 11, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples in README.md mostly (all?) 404
3 participants