This repository was archived by the owner on Jun 26, 2024. It is now read-only.
Add optional .spec.name to ServiceBinding to binding.operators.coreos.com/v1alpha1 API
#1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eos.com/v1alpha1 API` Until now, the binding name was set through `.metadata.name` of `ServiceBinding` resource, and that name was used in constructing binding mount point, i.e. `<SERVICE_BINDING_ROOT>/<binding name>` Since `.metadata.name` value must be unique within all `ServiceBinding` resources in a given namespace, the introduction of `.spec.name` allows us to overwrite `.metadata.name` and have more predictable mount points inside containers. This work alligns `binding.operators.coreos.com/v1alpha1 API` even further to the spec API: https://github.com/servicebinding/spec#resource-type-schema-1 Signed-off-by: Predrag Knezevic <[email protected]>
pedjak
requested review from
pmacik
and removed request for
isutton and
jasperchui
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
+ Coverage 57.77% 57.88% +0.11%
==========================================
Files 28 28
Lines 1570 1572 +2
==========================================
+ Hits 907 910 +3
+ Misses 545 544 -1
Partials 118 118
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the binding name was set through
.metadata.nameofServiceBindingresource,and that name was used in constructing binding mount point, i.e.
<SERVICE_BINDING_ROOT>/<binding name>Since
.metadata.namevalue must be unique within allServiceBindingresources in a given namespace,the introduction of
.spec.nameallows us to overwrite.metadata.nameand have more predictablemount points inside containers.
This work aligns
binding.operators.coreos.com/v1alpha1 APIeven further to the spec API:https://github.com/servicebinding/spec#resource-type-schema-1