Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Sep 28, 2021

The operator detects CustomResourceDefinitions exposing binding data
and reports bindable resource types (group, version, kind) within
cluster-scoped instance of BindableKinds, under .status field:

apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableKinds
metadata:
  name: bindable-kinds
status:
- group: stable.example.com
  kind: BindableBackend
  version: v1
.
.
.

There is only one instance of BindableKinds, named bindable-kinds

@openshift-ci openshift-ci bot requested review from isutton and sadlerap September 28, 2021 20:29
@pedjak pedjak changed the title Discover bindable kinds and expose them for consumption Detect bindable kinds and expose them for client discovery Sep 28, 2021
@pedjak
Copy link
Contributor Author

pedjak commented Sep 28, 2021

/retest

@pedjak pedjak requested review from pmacik and removed request for isutton September 29, 2021 08:54
@pedjak pedjak added this to the 0.11 milestone Sep 29, 2021
@pmacik
Copy link
Contributor

pmacik commented Sep 29, 2021

@pedjak The acceptance test Discover bindable service when defined by v1beta1 CRD API for 4.9 fails because CRD API v1beta1 is not supported in 4.9+, only v1 is.

@pedjak pedjak force-pushed the bindable-kinds branch 2 times, most recently from 8bcfbd0 to b96767d Compare September 29, 2021 14:30
The operator detects `CustomResourceDefinitions` exposing binding data
and reports bindable resource types (group, version, kind) within
cluster-scoped instance of `BindableKinds`, under `.status` field:

```
apiVersion: binding.operators.coreos.com/v1alpha1
kind: BindableKinds
metadata:
  name: bindable-kinds
status:
- group: stable.example.com
  kind: BindableBackend
  version: v1
.
.
.
```

There is only one instance of `BindableKinds`, named `bindable-kinds`

Signed-off-by: Predrag Knezevic <[email protected]>
@pedjak
Copy link
Contributor Author

pedjak commented Sep 29, 2021

/retest

@pmacik
Copy link
Contributor

pmacik commented Sep 29, 2021

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor

pmacik commented Sep 29, 2021

/retest

2 similar comments
@pedjak
Copy link
Contributor Author

pedjak commented Sep 29, 2021

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Sep 29, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2279319 into redhat-developer:master Sep 29, 2021
@pmacik pmacik linked an issue Feb 11, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a list of bindable services
3 participants