This repository was archived by the owner on Jun 26, 2024. It is now read-only.
[acceptance-tests] Use patch instead of apply for IDP setup to avoid braking cluster's IDPs #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Macík <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
+ Coverage 56.97% 57.01% +0.03%
==========================================
Files 28 28
Lines 1569 1568 -1
==========================================
Hits 894 894
+ Misses 558 557 -1
Partials 117 117
Continue to review full report at Codecov.
|
pmacik
changed the title
pedjak
approved these changes
Sep 27, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmacik
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the non-admin user account for acceptance tests is setup via
oc applycommand, which potentially ovewrites OAuth setup of the openshift cluster.Running the
openshift-setup.shscript multiple times might cause theoc loginwith theacceptance-tests-devuser to fail with:Changes
This PR:
OAuthfrom usingoc applycommand tooc patchto avoid breaking cluster's other IDPsTesting
Run
test/acceptance-tests/openshift-setup.shmultiple times. No login error should occur.