Skip to content

Upgrade api and img to mitigate CVE-2023-44487 #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

maysunfaisal
Copy link
Member

@maysunfaisal maysunfaisal commented Oct 25, 2023

What does this PR do?:

Mitigate CVE-2023-44487

  • Upgrade to gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0 and specify the flag --http2-disable=true, see
  • Upgrade k8s.io/api, k8s.io/client-go to v0.26.10
  • Upgrade k8s.io/apimachinery to v0.27.7
  • Disable http/2 on the webhook server by default, introduced Docker build arg ENABLE_WEBHOOK_HTTP2 to enable
  • Fetch the latest gitops generator library module
  • sigs.k8s.io/yaml has no new releases
  • Upgrade sigs.k8s.io/controller-runtime to v0.14.7 https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.7

Which issue(s)/story(ies) does this PR fixes:

restricted DEVHAS-539

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

Build an image and deploy it to HAS pod. Do a basic sniff test for Application and Component create. Remember to include the updated kube-rbac-proxy image in your test.

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@maysunfaisal maysunfaisal marked this pull request as ready for review October 26, 2023 20:02
Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Oct 26, 2023
@maysunfaisal
Copy link
Member Author

controller-runtime released 0.14.7 yesterday https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.7, so i will move up to this.

@maysunfaisal maysunfaisal removed the lgtm label Oct 27, 2023
@maysunfaisal maysunfaisal changed the title Upgrade api and img to mitigate CVE-2023-44487 [DO NOT MERGE] Upgrade api and img to mitigate CVE-2023-44487 Oct 27, 2023
@maysunfaisal maysunfaisal marked this pull request as draft October 27, 2023 20:47
@maysunfaisal maysunfaisal marked this pull request as ready for review October 30, 2023 20:31
@openshift-ci openshift-ci bot requested a review from johnmcollier October 30, 2023 20:31
@maysunfaisal maysunfaisal changed the title [DO NOT MERGE] Upgrade api and img to mitigate CVE-2023-44487 Upgrade api and img to mitigate CVE-2023-44487 Oct 30, 2023
@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,kim-tsao,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants