Add rector to migrate __sleep() to __serialize() #7212
Conversation
| foreach ($node->stmts as $stmt) { | ||
| if ($stmt instanceof Node\Stmt\Return_ && $stmt->expr instanceof Array_) { | ||
| $newItems = []; | ||
| foreach ($stmt->expr->items as $item) { | ||
| if ($item !== null && $item->value instanceof Node\Scalar\String_) { | ||
| $propName = $item->value->value; | ||
| $newItems[] = new ArrayItem( | ||
| new PropertyFetch(new Node\Expr\Variable('this'), $propName), | ||
| $item->value | ||
| ); | ||
| } | ||
| } | ||
| $stmt->expr->items = $newItems; | ||
| } | ||
| } |
There was a problem hiding this comment.
use betterNodeFinder->findReturnsScoped($node) to locate returns, and apply change/validate for its values, see example
arshidkv12
force-pushed
the
__sleep__
branch
from
9b6aa04 to
9ec79ce
Compare
| foreach ($return->expr->items as $item) { | ||
| if ($item !== null && $item->value instanceof Node\Scalar\String_) { | ||
| $propName = $item->value->value; | ||
| $newItems[] = new ArrayItem( |
There was a problem hiding this comment.
add $hasChanged = false init variable before loop, set $hasChanged = true after changed, verify $hasChanged before apply return, return null if no change
| ); | ||
| } | ||
| } | ||
| $return->expr->items = $newItems; |
There was a problem hiding this comment.
init $newItems inside inner loop, verify not empty before assign
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
check ! $hasChanged, return null
There was a problem hiding this comment.
Please check now.
There was a problem hiding this comment.
Could you give link of example the error/deprecation notice on https://3v4l.org/ for this case?
Also probably handle __wakeup as well.
Thank you.
Not implemented in PHP core yet. I think it will be added soon. I’ll add __wakeup soon. |
https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods