[PHP 8.5] Introduce PhpVersion::DEPRECATE_ORD_WITH_MULTIBYTE_STRING

[arshidkv12]

https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_passing_string_which_are_not_one_byte_long_to_ord

[samsonasik]

this needs check if $value is null which may can be fetch from variable:

function foo($x)
{
    echo ord($x);
}

which we don't know the context, so should be skipped.

[samsonasik]

when switch between branch on multiple PRs, please start over checkout from main instead of last branch so commits are not mixed up:

# eg: you're on foo branch from PR #123 
# you want to create new PR, then go back to main branch first
git checkout main

# register repo if not yet
git remote add upstream [email protected]:rectorphp/rector-src.git


# pull latest upstream main
git pull upstream main

# swith for new PR
git checkout new-bar

[arshidkv12]

Thank you

[arshidkv12]

 git pull upstream main                                                                               3 ✘   

[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights

[samsonasik]

You may need to use https:

git remote set-url upstream https://github.com/rectorphp/rector-src.git

[samsonasik]

please add test for:

$var = 123;
echo ord($var);

[samsonasik]

please add test for:

$var = 'abc';
echo ord($var);

[samsonasik]

probably verify its $argExpr type itself:

$type = $this->nodeTypeResolver->getNativeType($argExpr);

if (! $type->isInteger()->yes() && ! $type->isString()->yes()) {
    return null;
}