Skip to content

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Aug 11, 2025

Summary

Reported by phpstan [1]:

Variable $typesFiltered on left side of ?? always exists and is not nullable.

And yep indeed, array_filter cannot return null or undefine the var, so this is not necessary.

[1] https://github.com/rebing/graphql-laravel/actions/runs/16870256928/job/47783542319#step:8:14


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Reported by phpstan [1]:
> Variable $typesFiltered on left side of ?? always exists and is not nullable.

And yep indeed, `array_filter` cannot return `null` or undefine the var,
so this is not necessary.

[1] https://github.com/rebing/graphql-laravel/actions/runs/16870256928/job/47783542319#step:8:14
@mfn mfn self-assigned this Aug 11, 2025
@mfn mfn merged commit 2fa2dbe into rebing:master Aug 12, 2025
20 checks passed
@mfn mfn deleted the mfn/rm-coalesce branch August 12, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant