Versions: enforce using project.versions instead of Version.filter(project=project) #12411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilter(project=project)
|
Can we document this somehow? I'm sure we will be tempted to re add the project= argument we are removing now and use the slow version of the query again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Version.filter(project=project), django will re-fetch the project for each version when accessed, but when using
project.versionsdjango will share the same project instance on each version, so fewer queries and less memory is used. I checked and all querysets in public make use ofself.filter, so everything should work properly.There are probably more querysets that can benefit from a similar change, but this is just a start.