Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Remove usage of jquery#115

Merged
stsewd merged 4 commits intomainfrom
remove-some-jquery
Aug 3, 2022
Merged

Remove usage of jquery#115
stsewd merged 4 commits intomainfrom
remove-some-jquery

Conversation

@stsewd
Copy link
Copy Markdown
Member

@stsewd stsewd commented Jul 14, 2022

There are still more code that depends on jquery and underscorejs,
but this is a good start.

  • Use the fetch API instead of jquery's ajax.
  • Use the URL and URLSearchParams objects instead of our custom code
    to parse search parameters.
  • Had to update the tests, because the new version of selenium remove the find_element_by* methods (pytest-selenium installs the latest version by default).
  • Also updated pytest-selenium, which restricts the version of selenium to 4.x.

stsewd added 2 commits July 14, 2022 11:58
There are still more code that depends on jquery and underscorejs,
but this is a good start.

- Use the fetch API instead of jquery's ajax.
- Use the URL and URLSearchParams objects instead of our custom code
  to parse search parameters.
@stsewd stsewd marked this pull request as draft July 14, 2022 18:36
@stsewd stsewd requested review from a team, agjohnson and humitos July 14, 2022 20:01
@stsewd stsewd marked this pull request as ready for review July 14, 2022 20:02
Copy link
Copy Markdown

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@stsewd stsewd merged commit 5880a64 into main Aug 3, 2022
@stsewd stsewd deleted the remove-some-jquery branch August 3, 2022 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants