Skip to content

fix(anchor): ignore anchor hash when parsing internal link syntax#576

Merged
kevinports merged 1 commit intonextfrom
fix/special-char-in-anchor-hash
Sep 7, 2022
Merged

fix(anchor): ignore anchor hash when parsing internal link syntax#576
kevinports merged 1 commit intonextfrom
fix/special-char-in-anchor-hash

Conversation

@kevinports
Copy link
Contributor

@kevinports kevinports commented Aug 31, 2022

PR App Fix RM-2485

There's a bug with our internal link feature where if you pass a url hash of non-unicode characters as an anchor link, the href doesn't get parsed in the Anchor component.

Here's an example: https://busted-links.readme.io/docs/intercom-3

🧰 Changes

  • Ignore anchor hash when parsing internal link syntax that generates a link's path, and append the hash to the path string separately.

🧬 QA & Testing

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants