fix(anchor): ignore anchor hash when parsing internal link syntax#576
Merged
kevinports merged 1 commit intonextfrom Sep 7, 2022
Merged
fix(anchor): ignore anchor hash when parsing internal link syntax#576kevinports merged 1 commit intonextfrom
kevinports merged 1 commit intonextfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug with our internal link feature where if you pass a url hash of non-unicode characters as an anchor link, the
hrefdoesn't get parsed in theAnchorcomponent.Here's an example: https://busted-links.readme.io/docs/intercom-3
🧰 Changes
🧬 QA & Testing