Skip to content

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Nov 29, 2021

🧰 Changes

Updates a bunch of packages minor versions.

The snapshot updates are from puppeteer, it looks text or line height is being calculated slightly differently. I don't think this will effect the outputted code.

🧬 QA & Testing

  • tests pass?

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 November 29, 2021 20:38 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 18:54 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 18:57 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 19:46 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 19:59 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 20:19 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 20:26 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 20:27 Inactive
@@ -29,7 +29,7 @@
},
"dependencies": {
"@readme/emojis": "^4.0.0",
"@readme/syntax-highlighter": "^10.13.0",
"@readme/syntax-highlighter": "^10.13.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have that codemirror problem again with this one when you pull it over into the site, I'm not sure. Hopefully not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea, totally forgot about that.

"@semantic-release/git": "^10.0.1",
"babel-jest": "^27.4.0",
"babel-loader": "^8.2.3",
"codemirror": "^5.64.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might also cause problems, but hopefully not.

package.json Outdated
"rdme": "^5.1.4",
"prettier": "^2.5.0",
"puppeteer": "^12.0.1",
"rdme": "^5.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a v6 out now if you want to update this again.

Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the untethered to a review comments. looks ok though

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-374 December 6, 2021 22:15 Inactive
@kellyjosephprice kellyjosephprice merged commit 623a505 into next Dec 6, 2021
@kellyjosephprice kellyjosephprice deleted the chore/update-packages branch December 6, 2021 22:20
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.35.0-next.1

@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants