[2.x] Improve PHP 8.5+ support by avoiding deprecated switch case syntax #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on top of reactphp#264 porting that change to v2.
kubawerlos
approved these changes
Aug 14, 2025
This was referenced Aug 14, 2025
clue
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
@WyriHaximus Changes LGTM 👍
That said, this likely won't have a noticeable impact. As discussed earlier today, this would only affect Promise v2, which does not even have the PHP 8.4+ nullable types from #260 addressed due to BC concerns. For Promise v3, both fixes have already been merged, with a release for PHP 8.5+ outstanding this week as discussed in #264.
Applying these changes to Promise v2 shouldn't cause any harm and I agree the old syntax looks kind of weird, but it's unlikely we'll be able to support PHP 8.4+, let alone PHP 8.5+, on Promise v2 anyway.
clue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #264 porting that change to v2.