Skip to content

Run CI on PHP8.0 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Run CI on PHP8.0 #196

wants to merge 2 commits into from

Conversation

bzikarsky
Copy link
Contributor

No explanation needed

bzikarsky and others added 2 commits September 28, 2021 11:50
@bzikarsky
Run CI on PHP8.0
d8c338a
@bzikarsky
Use E_ALL for unittests
cc356b4 
Unittests were run without E_DEPRECATED. This can (and does) mask
potential errors that users may discover later.
@bzikarsky
Copy link
Contributor Author

bzikarsky commented Sep 28, 2021 •
edited
Loading

The second commit forces PHPunit to E_ALL. This uncovers one deprecation error. A fix for this errors can be found in #195

@SimonFrings SimonFrings mentioned this pull request Oct 7, 2021
Merged
@bzikarsky
Copy link
Contributor Author

Closing in favour of #197

@bzikarsky bzikarsky closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzikarsky @clue