Skip to content

Add type declarations for some() #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2020
Merged

Add type declarations for some() #172

merged 1 commit into from
Aug 8, 2020

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus added this to the v3.0.0 milestone Jul 1, 2020
@WyriHaximus WyriHaximus requested review from cboden, clue and jsor July 1, 2020 16:20
@clue clue removed the bug label Aug 8, 2020
@clue clue changed the title Add missing typehint to some's howMany Add type declarations for some() Aug 8, 2020
clue
clue approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM :shipit:

@clue clue merged commit d3d4ec3 into reactphp:master Aug 8, 2020
@WyriHaximus WyriHaximus deleted the add-missing-typehint-to-some-howMany branch August 8, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

@cboden cboden Awaiting requested review from cboden

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jsor @clue